Upgrade to newer Dokka and Knit #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhalanskyjb
requested changes
Jul 6, 2021
| externalDocumentationLink { | ||
| url.set(new URL('http:https://reactivex.io/RxJava/2.x/javadoc/')) | ||
| packageListUrl.set(projectDir.toPath().resolve("package.list").toUri().toURL()) | ||
| } |
There was a problem hiding this comment.
Looking through git grep externalDoc, I notice the lack of Swing and JavaFX modules. It looks like our documentation doesn't reference anything Swing-related, so such a directive is not needed there, but the same is not true for JavaFX.
Also, why does this look different from the way it's done in the reactive module? It looks much more succinct there, and I don't understand the difference between these two modules in this regard.
There was a problem hiding this comment.
FTR: discussed that reactive module leverages our kts extensions
Regarding JavaFX -- seems to be a general (not PR-related oversight) that should be fixed
Co-authored-by: dkhalanskyjb <[email protected]>
# Conflicts: # build.gradle # gradle.properties
anastasiiaSpaseeva-zz
pushed a commit
that referenced
this pull request
Jul 6, 2021
* Migrate to Dokka pre-1.5.0 Co-authored-by: Kamil Doległo <[email protected]> Co-authored-by: dkhalanskyjb <[email protected]>
anastasiiaSpaseeva-zz
pushed a commit
that referenced
this pull request
Jul 6, 2021
* Migrate to Dokka pre-1.5.0 Co-authored-by: Kamil Doległo <[email protected]> Co-authored-by: dkhalanskyjb <[email protected]>
anastasiiaSpaseeva-zz
pushed a commit
that referenced
this pull request
Jul 7, 2021
* Migrate to Dokka pre-1.5.0 Co-authored-by: Kamil Doległo <[email protected]> Co-authored-by: dkhalanskyjb <[email protected]>
anastasiiaSpaseeva-zz
pushed a commit
that referenced
this pull request
Jul 7, 2021
* Migrate to Dokka pre-1.5.0 Co-authored-by: Kamil Doległo <[email protected]> Co-authored-by: dkhalanskyjb <[email protected]>
anastasiiaSpaseeva-zz
pushed a commit
that referenced
this pull request
Jul 7, 2021
* Migrate to Dokka pre-1.5.0 Co-authored-by: Kamil Doległo <[email protected]> Co-authored-by: dkhalanskyjb <[email protected]>
woainikk
pushed a commit
that referenced
this pull request
Jul 9, 2021
* Migrate to Dokka pre-1.5.0 Co-authored-by: Kamil Doległo <[email protected]> Co-authored-by: dkhalanskyjb <[email protected]>
woainikk
pushed a commit
that referenced
this pull request
Jul 9, 2021
* Migrate to Dokka pre-1.5.0 Co-authored-by: Kamil Doległo <[email protected]> Co-authored-by: dkhalanskyjb <[email protected]>
woainikk
pushed a commit
that referenced
this pull request
Jul 12, 2021
* Migrate to Dokka pre-1.5.0 Co-authored-by: Kamil Doległo <[email protected]> Co-authored-by: dkhalanskyjb <[email protected]> (cherry picked from commit bcbcd16)
woainikk
pushed a commit
that referenced
this pull request
Jul 12, 2021
* Migrate to Dokka pre-1.5.0 Co-authored-by: Kamil Doległo <[email protected]> Co-authored-by: dkhalanskyjb <[email protected]>
woainikk
pushed a commit
that referenced
this pull request
Jul 12, 2021
* Migrate to Dokka pre-1.5.0 Co-authored-by: Kamil Doległo <[email protected]> Co-authored-by: dkhalanskyjb <[email protected]>
woainikk
added a commit
that referenced
this pull request
Jul 12, 2021
* Migrate to Dokka pre-1.5.0 Co-authored-by: Kamil Doległo <[email protected]> Co-authored-by: dkhalanskyjb <[email protected]> (cherry picked from commit bcbcd16)
woainikk
pushed a commit
that referenced
this pull request
Jul 12, 2021
* Migrate to Dokka pre-1.5.0 Co-authored-by: Kamil Doległo <[email protected]> Co-authored-by: dkhalanskyjb <[email protected]>
woainikk
added a commit
that referenced
this pull request
Jul 12, 2021
* Migrate to Dokka pre-1.5.0 Co-authored-by: Kamil Doległo <[email protected]> Co-authored-by: dkhalanskyjb <[email protected]>
pablobaxter
pushed a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
* Migrate to Dokka pre-1.5.0 Co-authored-by: Kamil Doległo <[email protected]> Co-authored-by: dkhalanskyjb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.