Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update R8 for Kotlin 1.5.0, enable DEX size metrics back #2739

Merged
merged 2 commits into from
Jun 4, 2021
Merged

Update R8 for Kotlin 1.5.0, enable DEX size metrics back #2739

merged 2 commits into from
Jun 4, 2021

Conversation

qwwdfsad
Copy link
Collaborator

@qwwdfsad qwwdfsad commented Jun 2, 2021

No description provided.

@dkhalanskyjb
Copy link
Collaborator

While you're here, maybe you could also do

kotlinx.coroutines/buildSrc/src/main/kotlin/RunR8.kt

Line 17 in 30f90ae

* TODO move back to kotlinx-coroutines-android when it's migrated to the kts

@qwwdfsad
Copy link
Collaborator Author

qwwdfsad commented Jun 4, 2021 •
edited
Loading

@dkhalanskyjb sure, good catch, done

@qwwdfsad qwwdfsad merged commit 582086c into develop Jun 4, 2021
@qwwdfsad qwwdfsad deleted the fix-r8 branch June 4, 2021 13:00
pablobaxter pushed a commit to pablobaxter/kotlinx.coroutines that referenced this pull request Sep 14, 2022
@qwwdfsad @pablobaxter
Update R8 for Kotlin 1.5.0, enable DEX size metrics back (Kotlin#2739)
3b6962a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhalanskyjb dkhalanskyjb dkhalanskyjb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qwwdfsad @dkhalanskyjb