Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dev repositories and Bintray usages where applicable #2587

Merged
merged 5 commits into from
Apr 22, 2021
Merged

Remove dev repositories and Bintray usages where applicable #2587

merged 5 commits into from
Apr 22, 2021

Conversation

qwwdfsad
Copy link
Collaborator

No description provided.

@qwwdfsad qwwdfsad requested a review from elizarov March 16, 2021 18:21
@qwwdfsad qwwdfsad marked this pull request as ready for review March 16, 2021 18:21
@qwwdfsad qwwdfsad removed the request for review from elizarov March 16, 2021 18:40
@qwwdfsad
Copy link
Collaborator Author

Filed #2590

@qwwdfsad qwwdfsad requested a review from elizarov March 17, 2021 11:21
elizarov
elizarov suggested changes Apr 21, 2021
View reviewed changes
js/example-frontend-js/build.gradle.kts Outdated Show resolved Hide resolved
js/example-frontend-js/build.gradle.kts Outdated Show resolved Hide resolved
build.gradle
}
}
// Leftover until we migrated to Dokka 1.4.30
maven { url "https://kotlin.bintray.com/kotlin-dev" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this one should also conditionally use a cache-redirected URL ("https://cache-redirector.jetbrains.com/maven.pkg.jetbrains.space/kotlin/p/kotlin/dev") to be fully bintray-independent on our CI.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already being conditionally redirected, isn't it? https://github.com/Kotlin/kotlinx.coroutines/blob/master/build.gradle#L82

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Missed it!

@qwwdfsad qwwdfsad requested a review from elizarov April 21, 2021 16:07
elizarov
elizarov approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marvelous!

@qwwdfsad qwwdfsad merged commit 347feed into develop Apr 22, 2021
@qwwdfsad qwwdfsad deleted the bintray-leftovers branch April 22, 2021 09:58
pablobaxter pushed a commit to pablobaxter/kotlinx.coroutines that referenced this pull request Sep 14, 2022
@qwwdfsad @pablobaxter
Remove dev repositories and Bintray usages where applicable (Kotlin#2587
2da7106 
)

* Remove dev repositories and Bintray usages where applicable
* Update our frontend example
* Update lincheck
* Temporary ignore MutexLincheckTest.modelCheckingTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizarov elizarov elizarov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qwwdfsad @elizarov