Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build script compilation issues #2574

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Fix build script compilation issues #2574

merged 1 commit into from
Mar 9, 2021

Conversation

Tapchicoma
Copy link
Contributor

They were deprecated long time ago and were removed in Gradle 7.

ALikhachev
ALikhachev approved these changes Mar 9, 2021
View reviewed changes
integration-testing/build.gradle Outdated Show resolved Hide resolved
@qwwdfsad qwwdfsad self-requested a review March 9, 2021 14:06
qwwdfsad
qwwdfsad requested changes Mar 9, 2021
View reviewed changes
Copy link
Collaborator

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build does not pass, Gradle couldn't resolve dependencies now, please address it and ensure that the project is buildable

@Tapchicoma
Replace deprecated '*compile' configurations.
6af3161 
They were deprecated long time ago and were removed in Gradle 7.
@Tapchicoma Tapchicoma changed the base branch from kotlinx.train to develop March 9, 2021 14:26
@Tapchicoma Tapchicoma requested a review from qwwdfsad March 9, 2021 15:06
qwwdfsad
qwwdfsad approved these changes Mar 9, 2021
View reviewed changes
Copy link
Collaborator

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of it

@qwwdfsad qwwdfsad merged commit a8d55d6 into develop Mar 9, 2021
@qwwdfsad qwwdfsad deleted the yahor/fix-compilation-issue branch March 9, 2021 15:39
anastasiiaSpaseeva-zz pushed a commit that referenced this pull request Mar 9, 2021
@Tapchicoma
Replace deprecated '*compile' configurations. (#2574)
3d9fe06 
They were deprecated long time ago and were removed in Gradle 7
anastasiiaSpaseeva-zz pushed a commit that referenced this pull request Apr 11, 2021
@Tapchicoma
Replace deprecated '*compile' configurations. (#2574)
5dd9e64 
They were deprecated long time ago and were removed in Gradle 7
anastasiiaSpaseeva-zz pushed a commit that referenced this pull request Apr 22, 2021
@Tapchicoma
Replace deprecated '*compile' configurations. (#2574)
dac9951 
They were deprecated long time ago and were removed in Gradle 7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ALikhachev ALikhachev ALikhachev approved these changes

@qwwdfsad qwwdfsad qwwdfsad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tapchicoma @ALikhachev @qwwdfsad