Support JetBrains cache-redirector service for stable CI builds #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On CI set CACHE_REDIRECTOR=true environment property.
qwwdfsad
reviewed
Sep 14, 2020
| val msg = "Repository $url in $containerName should be cached with cache-redirector" | ||
| val details = "Using non cached repository may lead to download failures in CI builds." + | ||
| " Check buildSrc/src/main/kotlin/CacheRedirector.kt for details." | ||
| logger.warn("WARNING - $msg\n$details") |
There was a problem hiding this comment.
Nobody will see this warning until builds start to fail.
Maybe a better strategy is to fail-fast, so the maintainer (this script is going to be copy-pasted :)) will see the failure, file an issue and mute the problem only then.
There was a problem hiding this comment.
It is not a test, so the only thing I can do is to hard-fail here, which is too much. I've tried doing it as a test (that's what kotlin project does), but that turned out to be quite complicated due to various technical issues, since I want to verify repositories in all projects and buildscript.
recheej
pushed a commit
to recheej/kotlinx.coroutines
that referenced
this pull request
Dec 28, 2020
…in#2247) On CI set CACHE_REDIRECTOR=true environment property.
recheej
pushed a commit
to recheej/kotlinx.coroutines
that referenced
this pull request
Dec 28, 2020
…in#2247) On CI set CACHE_REDIRECTOR=true environment property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On CI set CACHE_REDIRECTOR=true environment property.