Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race in Flow.asPublisher #2124

Merged
merged 4 commits into from
Jul 16, 2020
Merged

Fix race in Flow.asPublisher #2124

merged 4 commits into from
Jul 16, 2020

Conversation

elizarov
Copy link
Contributor

@elizarov elizarov commented Jul 7, 2020

The race was leading to emitting more items via onNext than requested, the corresponding stress-test was added, too

Fixes #2109

The race was leading to emitting more items via onNext than requested, the corresponding stress-test was added, too

Fixes #2109
@elizarov elizarov requested a review from qwwdfsad July 7, 2020 09:25
Copy link
Collaborator

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with writing a stable reproducer!

@elizarov elizarov merged commit d718970 into develop Jul 16, 2020
@elizarov elizarov deleted the flow-as-publisher-race branch July 16, 2020 15:33
recheej pushed a commit to recheej/kotlinx.coroutines that referenced this pull request Dec 28, 2020
The race was leading to emitting more items via onNext than requested, the corresponding stress-test was added, too

Fixes Kotlin#2109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants