Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements of debugging experience #2093

Merged
merged 3 commits into from
Jun 17, 2020
Merged

Conversation

qwwdfsad
Copy link
Collaborator

Recognizable toString is not only pretty and aligned with our own glossary, but also significantly affects "group by dispatcher" feature in the upcoming IDEA debugger, see the screenshot: https://imgur.com/a/2zqM5pn

The second commit is just nice to have while we are here

@qwwdfsad qwwdfsad requested a review from elizarov June 16, 2020 18:33
@qwwdfsad
Copy link
Collaborator Author

Dispatchers.Main is coming a bit later

Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Great

@qwwdfsad qwwdfsad merged commit ad542c4 into develop Jun 17, 2020
@qwwdfsad qwwdfsad deleted the debugging-experience branch June 17, 2020 11:43
@elizarov elizarov mentioned this pull request Jul 16, 2020
1 task
recheej pushed a commit to recheej/kotlinx.coroutines that referenced this pull request Dec 28, 2020
* Recognizable toString implementation in default dispatchers
* Fast-path for disabled debug probes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants