Fix publication validator not looking in the local maven repository #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the change of the publication validator, a bug was introduced that led to MavenPublicationValidator being run not on the artifacts from the local Maven repository but on classfiles from the corresponding subproject. This is a problem because this test is for the behavior of the atomicfu plugin, which could in theory produce nice classfiles in one place but wrong ones in the other, and the only important thing to test is whether the published classfiles are good. Now, this is fixed.
qwwdfsad
approved these changes
Mar 27, 2020
qwwdfsad
pushed a commit
that referenced
this pull request
Apr 24, 2020
…1880) During the change of the publication validator, a bug was introduced that led to MavenPublicationValidator being run not on the artifacts from the local Maven repository but on classfiles from the corresponding subproject. This is a problem because this test is for the behavior of the atomicfu plugin, which could in theory produce nice classfiles in one place but wrong ones in the other, and the only important thing to test is whether the published classfiles are good. Now, this is fixed.
recheej
pushed a commit
to recheej/kotlinx.coroutines
that referenced
this pull request
Dec 28, 2020
…otlin#1880) During the change of the publication validator, a bug was introduced that led to MavenPublicationValidator being run not on the artifacts from the local Maven repository but on classfiles from the corresponding subproject. This is a problem because this test is for the behavior of the atomicfu plugin, which could in theory produce nice classfiles in one place but wrong ones in the other, and the only important thing to test is whether the published classfiles are good. Now, this is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the change of the publication validator, a bug was
introduced that led to MavenPublicationValidator being run not on
the artifacts from the local Maven repository but on classfiles
from the corresponding subproject. This is a problem because this
test is for the behavior of the atomicfu plugin, which could in
theory produce nice classfiles in one place but wrong ones in the
other, and the only important thing to test is whether the
published classfiles are good.
Now, this is fixed.