Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more typos; reword some phrases; add "job:" to textual output in … #1154

Merged
merged 2 commits into from
May 6, 2019

Conversation

Inego
Copy link
Contributor

@Inego Inego commented Apr 29, 2019

…examples

to better differentiate between the "main" and "job" coroutines

…examples

to better differentiate between the "main" and "job" coroutines
@qwwdfsad qwwdfsad self-requested a review April 30, 2019 14:54
Copy link
Collaborator

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort!
Could you please also run ./gradlew knit and commit generated changes as well?

@Inego
Copy link
Contributor Author

Inego commented Apr 30, 2019

I guess I'm doing something wrong...

> Task :kotlinx-coroutines-android:dokka FAILED
:kotlinx-coroutines-android:dokka (Thread[Task worker for ':',5,main]) completed. Took 3.257 secs.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':kotlinx-coroutines-android:dokka'.
> Guice provision errors:

  1) Error injecting constructor, java.lang.RuntimeException: Exception while loading package-list from ExternalDocumentationLinkImpl(url=https://kotlin.github.io/kotlinx.coroutines/kotlinx-coroutines-core/, packageListUrl=file:https://G:/Projects/github/Inego/kotlinx.co
routines/kotlinx-coroutines-core/build/dokka/kotlinx-coroutines-core/package-list)
    at org.jetbrains.dokka.ExternalDocumentationLinkResolver.<init>(ExternalDocumentationLinkResolver.kt:27)
    at org.jetbrains.dokka.ExternalDocumentationLinkResolver.class(ExternalDocumentationLinkResolver.kt:27)
    while locating org.jetbrains.dokka.ExternalDocumentationLinkResolver
      for parameter 4 at org.jetbrains.dokka.DeclarationLinkResolver.<init>(DeclarationLinkResolver.kt:13)
    while locating org.jetbrains.dokka.DeclarationLinkResolver
      for parameter 0 at org.jetbrains.dokka.PackageDocs.<init>(PackageDocs.kt:13)
    at org.jetbrains.dokka.PackageDocs.class(PackageDocs.kt:12)
    while locating org.jetbrains.dokka.PackageDocs

@Inego
Copy link
Contributor Author

Inego commented Apr 30, 2019

I'm on Windows and here's what my gradlew.bat is using:

------------------------------------------------------------
Gradle 4.10
------------------------------------------------------------

Build time:   2018-08-27 18:35:06 UTC
Revision:     ee3751ed9f2034effc1f0072c2b2ee74b5dce67d

Kotlin DSL:   1.0-rc-3
Kotlin:       1.2.60
Groovy:       2.4.15
Ant:          Apache Ant(TM) version 1.9.11 compiled on March 23 2018
JVM:          1.8.0_212-8u ( 25.212-b03)
OS:           Windows 10 10.0 amd64

@elizarov
Copy link
Contributor

elizarov commented Apr 30, 2019

I guess I'm doing something wrong...

You did right, but there was an intermittent problem with loading package-list for Android docs, as it seems. We need to fix it, though. This bothers us from time to time, too. Here is an issue for it: #648

@Inego
Copy link
Contributor Author

Inego commented May 1, 2019

I forgot to copy and paste the last diagnostic line from the knit output above:

Unknown host 'G'.

Please ensure the host name is correct. If you are behind an HTTP proxy, please configure the proxy settings either in IDE or Gradle.

It must be the drive letter "G" from the local (Windows) file path packageListUrl=file:https://G:/Projects/github/Inego/kotlinx.coroutines/kotlinx-coroutines-core/build/dokka/kotlinx-coroutines-core/package-list.

@Inego
Copy link
Contributor Author

Inego commented May 6, 2019

Knit done, changes committed.

@elizarov
Copy link
Contributor

elizarov commented May 6, 2019

Thanks!

@elizarov elizarov merged commit 563b7e5 into Kotlin:master May 6, 2019
@Inego Inego deleted the patch-2 branch May 6, 2019 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants