Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompletableJob.asCompletableFuture #1113

Merged
merged 2 commits into from
Apr 23, 2019
Merged

CompletableJob.asCompletableFuture #1113

merged 2 commits into from
Apr 23, 2019

Conversation

qwwdfsad
Copy link
Collaborator

Fixes #1104

@qwwdfsad qwwdfsad requested a review from elizarov April 18, 2019 08:49
@qwwdfsad qwwdfsad force-pushed the develop branch 3 times, most recently from 1837412 to 1748ce1 Compare April 18, 2019 11:49
@qwwdfsad qwwdfsad added this to the 1.2.1 milestone Apr 19, 2019
@qwwdfsad qwwdfsad requested a review from elizarov April 22, 2019 17:39
elizarov
elizarov approved these changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with minor doc notes.

integration/kotlinx-coroutines-jdk8/src/future/Future.kt Outdated Show resolved Hide resolved
integration/kotlinx-coroutines-jdk8/src/future/Future.kt Outdated Show resolved Hide resolved
@qwwdfsad qwwdfsad merged commit fcfabee into develop Apr 23, 2019
@qwwdfsad qwwdfsad deleted the job-as-future branch April 23, 2019 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizarov elizarov elizarov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@qwwdfsad @elizarov