-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
completionHandler
is now an internal API of the ReceiveChannel
operators - what's the alternative?
#994
Comments
Yes, this is how it is actually implemented internally. Also, probably this is a good argument for #934
Not the part with This API became internal because we are currently actively prototyping cold-streams. |
I wrote two custom RxJava style operators until #437 / #254 are addressed. I want to ensure that they are cleaned up correctly, so I leveraged
onCompletion = consumesAll(*sources)
. My0.x
code is below:Unfortunately for me, the
1.x
APIs for this are now an@InternalCoroutinesApi
because of their use of theonCompletion: CompletionHandler
. How can I modify these I don't need to rely on the internalonCompletion
API?Would changing it to the following be a safe alternative? If so, could this be pointed out in the documentation?
The text was updated successfully, but these errors were encountered: