KRPC-97 Race condition in stream cancellation locks the transport #138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Stream cancellation
Problem Description
There might be a race condition between
StreamEnd
andStreamCancel
messages, resulting in a deadlock inincomingChannelOf
waits for the cannel that was already removed and will never be presentSolution
Added a
closedStreams
set that checks for such already closed streams and if on is closed - does not wait to close it once again