Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component separation #7

Merged
merged 9 commits into from
Feb 19, 2023
Merged

Component separation #7

merged 9 commits into from
Feb 19, 2023

Conversation

KonstantinGasser
Copy link
Owner

While thinking about next features for scotty I noticed that the pager component was simply doing too much which was unrelated to paging the logs. The pager would also implement logic to format and brows the logs... As such I started separating the components and smarten up the App component.

Logic now:

App:

  • decides what to show, propagates messages from the multiplexer to the current active view.
  • listens for user input and invokes views accordingly

Pager:

  • only deals with reading latest N items from the buffer and displaying them

Formatter:

  • only deals with formatting a log and allows to brows through the logs

@KonstantinGasser KonstantinGasser added the enhancement New feature or request label Feb 16, 2023
@KonstantinGasser KonstantinGasser self-assigned this Feb 16, 2023
@KonstantinGasser KonstantinGasser merged commit a9c5cf1 into main Feb 19, 2023
@KonstantinGasser KonstantinGasser deleted the component_separation branch April 15, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant