adding color configuration from static to yaml #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
KonstantinGasser
requested changes
Mar 27, 2023
There was a problem hiding this comment.
Generally it LGTM.
Let's debate about one thing which is the location of the config file. Based on your current implementation the config.yaml would need to be located where ever the scotty command is called, do I understand that correctly?
Maybe we should aim for a common place say $HOME/.scotty/config.yaml, what are your thoughts?
Also we should fallback to default values in case no config exits, so that we do not force the user to have a config
|
Yea that's a good point, would be way more useful for the enduser to have their config and one central place |
…d implementing default color
KonstantinGasser
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the static color configuration (as mentioned in the issue https://github.com/KonstantinGasser/scotty/issues/2 to a color config which loads a "config.yaml".