Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(opentelemetry): add referenceable attribute to fields that could be stored in vaults #9611

Merged
merged 4 commits into from
Nov 17, 2022
Merged

feat(opentelemetry): add referenceable attribute to fields that could be stored in vaults #9611

merged 4 commits into from
Nov 17, 2022

Conversation

mayocream
Copy link
Contributor

@mayocream mayocream commented Oct 25, 2022 •
edited
Loading

Summary

Add referenceable=true attribute to plugin schema fields that could be stored in vaults.

FTI-4429

Note: please merge with "rebase strategy" to keep the commits history.

@mayocream mayocream requested a review from a team as a code owner October 25, 2022 01:54
@mayocream mayocream added this to the 3.1 milestone Oct 25, 2022
@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 25, 2022
@mayocream mayocream force-pushed the feat/otel-secrets branch 2 times, most recently from 59b8ddf to 16cbe1b Compare October 25, 2022 06:58
@mayocream mayocream force-pushed the feat/otel-secrets branch 2 times, most recently from 6ba3110 to 4cdf398 Compare October 26, 2022 06:02
@hbagdi hbagdi requested a review from flrgh October 26, 2022 17:09
@hbagdi
Copy link
Member

hbagdi commented Oct 28, 2022

@mayocream Please rebase.

@hbagdi hbagdi requested a review from gszr November 2, 2022 17:14
@mayocream mayocream force-pushed the feat/otel-secrets branch 2 times, most recently from 090c54f to 6cf3745 Compare November 3, 2022 04:59
mayocream added a commit that referenced this pull request Nov 3, 2022
@mayocream
docs(changelog): add entry for #9611
9a1d99f
@fffonion
Copy link
Contributor

fffonion commented Nov 4, 2022

one unit test is failing and looks relevant https://github.com/Kong/kong/actions/runs/3383824165/jobs/5620091308

@fffonion fffonion merged commit cb5e046 into master Nov 17, 2022
@fffonion fffonion deleted the feat/otel-secrets branch November 17, 2022 05:30
oowl pushed a commit that referenced this pull request Jul 15, 2024
@windmgc
fix(clustering): adjust clustering compatible check about aws-lambda …
565f2c1 
…plugin's new field empty_arrays_mode (#9613)

This PR fixes the clustering compatible check logic, due to the feature #9370 being backported to 3.5 ~ 3.7 series.

Related PRs:
#9609
#9610
#9611

https://konghq.atlassian.net/browse/FTI-5937
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fffonion fffonion fffonion approved these changes

@flrgh flrgh Awaiting requested review from flrgh

@gszr gszr Awaiting requested review from gszr

Assignees

@gszr gszr

Labels
changelog core/db plugins/opentelemetry size/L
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@mayocream @hbagdi @fffonion @gszr