Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should not print error message with exit code 1 when status != 200 #8101

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix: should not print error message with exit code 1 when status != 200 #8101

merged 1 commit into from
Oct 21, 2024

Conversation

ihexxa
Copy link
Contributor

@ihexxa ihexxa commented Oct 18, 2024 •
edited
Loading

Changes

  • Disable response code check and error messaging in runner execution

More details in INS-4586

@ihexxa ihexxa self-assigned this Oct 18, 2024
@ihexxa ihexxa marked this pull request as draft October 18, 2024 02:17
@ihexxa ihexxa changed the title fix: should not print error message when status != 200 with exit code 1 fix: should not print error message with exit code 1 when status != 200 Oct 18, 2024
@ihexxa ihexxa requested a review from a team October 18, 2024 03:01
@ihexxa ihexxa marked this pull request as ready for review October 18, 2024 03:01
@cwangsmv cwangsmv self-requested a review October 21, 2024 05:40
cwangsmv
cwangsmv approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@cwangsmv cwangsmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ihexxa ihexxa enabled auto-merge (squash) October 21, 2024 06:22
@ihexxa ihexxa merged commit 47f61b3 into develop Oct 21, 2024
8 checks passed
@ihexxa ihexxa deleted the fix/cli/resp-error-msg branch October 21, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwangsmv cwangsmv cwangsmv approved these changes

@filfreire filfreire filfreire approved these changes

Assignees

@ihexxa ihexxa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ihexxa @filfreire @cwangsmv