Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: return friendly message when sendRequest sees an error #7911

Merged
merged 1 commit into from
Sep 6, 2024
Merged

chore: return friendly message when sendRequest sees an error #7911

merged 1 commit into from
Sep 6, 2024

Conversation

ihexxa
Copy link
Contributor

@ihexxa ihexxa commented Sep 4, 2024

Changes:

  • chore: return friendly message when sendRequest sees an error
image

@ihexxa ihexxa self-assigned this Sep 4, 2024
@ihexxa ihexxa marked this pull request as draft September 4, 2024 09:55
@jackkav
Copy link
Contributor

jackkav commented Sep 4, 2024

this shouldn't be an unhandled error, it should appear in the response pane, it is an expected response when a users api is down.

@ihexxa ihexxa marked this pull request as ready for review September 5, 2024 07:54
jackkav
jackkav approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@jackkav jackkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If its easy to show this error in the preview pane id suggest doing it now, because it will be more difficult to do it later.

@ihexxa ihexxa enabled auto-merge (squash) September 6, 2024 02:26
@ihexxa ihexxa merged commit 58bea08 into develop Sep 6, 2024
8 checks passed
@ihexxa ihexxa deleted the chore/send-req-error-msg branch September 6, 2024 03:18
@ihexxa
Copy link
Contributor Author

ihexxa commented Sep 6, 2024

Probably we could check how to categorize them in the next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkav jackkav jackkav approved these changes

Assignees

@ihexxa ihexxa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ihexxa @jackkav