Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: flatten and reduce tsconfigs #7716

Merged
merged 11 commits into from
Jul 15, 2024
Merged

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented Jul 12, 2024

Motivation:

inso architecture is tangled and complex
build and type-checking parameters are merged and inherited and confusing
inspired by https://www.totaltypescript.com/tsconfig-cheat-sheet
aiming to flatten and make specific the tsconfigs required to type-check and build the inso cli
The eventual goal is to make the inso build process easier to maintain by removing steps or simplifying them
This PR could also affect type-checking in the app, but the worthy subgoal is for it to be easier to modify tsconfigs to add strictness

  • removed type check in build:sr
  • removed tsconfig.build.json
  • grouped tsconfig options
  • removed unused lines in package.json and tsconfig.json

future work

  • add more strictness to tsconfig with verbatimModuleSyntax (#7718), noUncheckedIndexedAccess

@jackkav jackkav changed the title Types/json-path refactor: flatten and reduce tsconfigs Jul 14, 2024
@jackkav jackkav marked this pull request as ready for review July 14, 2024 10:29
@jackkav jackkav requested a review from a team July 14, 2024 10:29
@jackkav jackkav merged commit e711bff into Kong:develop Jul 15, 2024
8 checks passed
@jackkav jackkav deleted the types/json-path branch July 15, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants