feat(Request pane): Add indicators for body and auth in the request pane tabs #7697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkav
reviewed
Jul 11, 2024
| @@ -93,6 +94,8 @@ export const RequestPane: FC<Props> = ({ | |||
| const contentType = | |||
| getContentTypeFromHeaders(activeRequest.headers) || | |||
| activeRequest.body.mimeType; | |||
| const isBodyEmpty = Boolean(typeof activeRequest.body.mimeType !== 'string' && !activeRequest.body.text); | |||
| const hasAuthentication = getAuthObjectOrNull(activeRequest.authentication)?.type !== 'none'; | |||
There was a problem hiding this comment.
Inherit from parent is considered not empty
inherit from parent is the default state, so perhaps this should read isNoneOrInherited rather than hasAuthentication
2faac18 to
914bd3e
Compare
914bd3e to
7df4461
Compare
jackkav
approved these changes
Jul 12, 2024
filfreire
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights:
None.Inherit from parentis considered not emptyNo Body