Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add smoke test for git-sync [INS-4132] #7682

Merged

Conversation

filfreire
Copy link
Member

@filfreire filfreire commented Jul 9, 2024

Closes INS-4132

Adds a basic prerelease test where we clone, checkout a different branch, and commit changes, while checking local history.

Pull and push are not in the initial implementation, but there is a way, pending discussion with rest of @Kong/team-insomnia:

  • We can define GH actions secret, with a GH access token with enough permissions to push a commit to a branch
  • Pass that access token on the GH prerelease test workflow as a env variable (see doc)
  • And checkout a designated separate branch of insomnia-git-example where we push a commit with a timestamp or a UUID to check pushing works ok.

Pros/cons - it would be overkill for regular smoke checks, but for prerelease ones I believe it's acceptable.

@filfreire filfreire requested a review from a team July 9, 2024 16:04
@filfreire filfreire force-pushed the feat/ins-4132-prerelease-git-sync-test branch from 95fd9ac to 8695bef Compare July 10, 2024 08:25
@jackkav
Copy link
Contributor

jackkav commented Jul 10, 2024

Move it to smoke tests and we are cooking 🧑‍🍳

@jackkav jackkav changed the title chore: add prerelease test for git-sync [INS-4132] chore: add smoke test for git-sync [INS-4132] Jul 10, 2024
@jackkav jackkav merged commit 39a2f37 into Kong:develop Jul 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants