Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use SSE for storage control updates #7661

Merged
merged 27 commits into from
Jul 16, 2024

Conversation

pavkout
Copy link
Contributor

@pavkout pavkout commented Jul 4, 2024

Fixes Implemented:

  • Implemented immediate display of error messages when admins change storage rules for the cloud application.
  • Added listener for the new StorageRuleChanged message.
  • Display the server error messages for PROJECT_STORAGE_RESTRICTION errors.
  • Addressed the issue where attempting to create a new cloud project as a member displayed an error modal, which reappeared when trying to create a local vault project subsequently.
  • Always show a warning message when creating or updating a project if the storage rule is not cloud_plus_local.

Notes for Team Discussion:

  1. The fourth fix on the list is a quick solution. If preferred, I can revert this change and address it more efficiently in a separate PR.
  2. For handling storage rules, I utilized network cache instead of localStorage. If there are concerns about this approach, let's use localStorage or discuss about alternative solutions.

Closes INS-4113
Related BE PR INS-4108

@pavkout pavkout self-assigned this Jul 4, 2024
@pavkout pavkout requested a review from a team July 4, 2024 00:10
@filfreire
Copy link
Member

@pavkout we rebased your branch with latest develop to help test for one of @marckong 's PRs in the API

packages/insomnia/src/ui/routes/organization.tsx Outdated Show resolved Hide resolved
packages/insomnia/src/ui/routes/organization.tsx Outdated Show resolved Hide resolved
packages/insomnia/src/ui/routes/project.tsx Outdated Show resolved Hide resolved
packages/insomnia/src/ui/routes/organization.tsx Outdated Show resolved Hide resolved
@CurryYangxx CurryYangxx requested a review from a team July 8, 2024 08:49
@pavkout pavkout force-pushed the fix-storage-error-messages branch from 97544ae to 4e0b04f Compare July 8, 2024 16:22
@pavkout pavkout requested a review from CurryYangxx July 11, 2024 10:55
@pavkout pavkout force-pushed the fix-storage-error-messages branch from ff642e4 to 6ba2d90 Compare July 15, 2024 13:36
@pavkout
Copy link
Contributor Author

pavkout commented Jul 15, 2024

@CurryYangxx Just finished the changes we discussed. Feel free to test it and review them one more time, and let's have a try it session one more time tomorrow morning.

CurryYangxx
CurryYangxx previously approved these changes Jul 16, 2024
@CurryYangxx CurryYangxx enabled auto-merge (squash) July 16, 2024 10:07
@CurryYangxx CurryYangxx merged commit f92d78a into Kong:develop Jul 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants