Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: folder scripts are not executed if request script is not enabled #7646

Merged
merged 4 commits into from
Jul 3, 2024
Merged

fix: folder scripts are not executed if request script is not enabled #7646

merged 4 commits into from
Jul 3, 2024

Conversation

ihexxa
Copy link
Contributor

@ihexxa ihexxa commented Jul 3, 2024 •
edited
Loading

Changes

  • fix: check joined script length instead of current script state
  • added tests
  • refactored and flattened functions for running scripts, and timing of the after-response script step will always be displayed, which is consistent with pre script step.

Ref: INS-4107 #7637

@ihexxa ihexxa self-assigned this Jul 3, 2024
@ihexxa ihexxa force-pushed the fix/folder-script-not-run branch from 07e7e81 to b2db106 Compare July 3, 2024 03:25
@ihexxa ihexxa enabled auto-merge (squash) July 3, 2024 06:56
@ihexxa ihexxa force-pushed the fix/folder-script-not-run branch from b6e8fe4 to 3ac555a Compare July 3, 2024 06:56
@ihexxa ihexxa merged commit 1ba964e into develop Jul 3, 2024
6 checks passed
@ihexxa ihexxa deleted the fix/folder-script-not-run branch July 3, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkav jackkav jackkav approved these changes

Assignees

@ihexxa ihexxa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ihexxa @jackkav