-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: enable active global environment and map it to the sdk #7533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihexxa
force-pushed
the
feat-script-global
branch
from
June 20, 2024 03:03
544c98f
to
74eecfc
Compare
ihexxa
force-pushed
the
feat-script-global
branch
from
June 20, 2024 11:57
4ab270b
to
109a5fe
Compare
ihexxa
force-pushed
the
feat-script-global
branch
from
June 21, 2024 02:42
109a5fe
to
10cca70
Compare
jackkav
reviewed
Jun 21, 2024
jackkav
reviewed
Jun 21, 2024
ihexxa
commented
Jun 24, 2024
|
CurryYangxx
approved these changes
Jun 26, 2024
stefancruz
pushed a commit
to stefancruz/insomnia
that referenced
this pull request
Jun 30, 2024
…g#7533) * feat: refactor the environment mapping between inso and script sdk * feat: enable global environment in the sdk * fix: disable global cases * refactor: pass select global env to script execution and persist it after execution * fix: lint error * fix: some minor fixes * fix: undefined is persisted as globals * chore: add some comments about the mapping rule * refactor: enable menu items for global environment manipulation (Kong#7589)
ihexxa
added a commit
that referenced
this pull request
Jul 3, 2024
* feat: refactor the environment mapping between inso and script sdk * feat: enable global environment in the sdk * fix: disable global cases * refactor: pass select global env to script execution and persist it after execution * fix: lint error * fix: some minor fixes * fix: undefined is persisted as globals * chore: add some comments about the mapping rule * refactor: enable menu items for global environment manipulation (#7589)
CurryYangxx
pushed a commit
that referenced
this pull request
Jul 5, 2024
* feat: refactor the environment mapping between inso and script sdk * feat: enable global environment in the sdk * fix: disable global cases * refactor: pass select global env to script execution and persist it after execution * fix: lint error * fix: some minor fixes * fix: undefined is persisted as globals * chore: add some comments about the mapping rule * refactor: enable menu items for global environment manipulation (#7589)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This changes hooks the active global environment to the script runtime, and enable them in scripting.
Ref: INS-3988
Tests are failing because it requires #7511
Changes