Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: init the hidden window when renderers are reloaded #7428

Merged
merged 5 commits into from
May 22, 2024

Conversation

ihexxa
Copy link
Contributor

@ihexxa ihexxa commented May 17, 2024

Changes

  • fix: init the hidden window when renderers are reloaded

Ref: INS-3856

ideas for future work

  • combine BrowserWindow and busy state to make syncing simpler
image

@ihexxa ihexxa self-assigned this May 17, 2024
@ihexxa ihexxa requested a review from a team May 21, 2024 06:30
Copy link
Contributor

@jackkav jackkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please describe the nature of this change in the PR description its quite hard to understand.

@ihexxa
Copy link
Contributor Author

ihexxa commented May 21, 2024

@jackkav Sure, I added some info or we could have some chat also.

jackkav
jackkav previously approved these changes May 21, 2024
@jackkav jackkav merged commit e5ce4cd into develop May 22, 2024
7 checks passed
@jackkav jackkav deleted the fix-reload-renderer branch May 22, 2024 07:29
stefancruz pushed a commit to stefancruz/insomnia that referenced this pull request Jun 30, 2024
* fix: init the hidden window when renderers are reloaded

* fix: missing some smoke test stuff after merging

* feedback

---------

Co-authored-by: jackkav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants