fixes codemirror measure issue #7391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatzjames
approved these changes
May 10, 2024
2f95997
to
4c9355f
Compare
filfreire
approved these changes
May 10, 2024
stefancruz
pushed a commit
to stefancruz/insomnia
that referenced
this pull request
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-resizable-panels are interacting with codemirror
codemirror has a css class called codemirror-measure used to estimate the pixel height of the parent element in order to render the content.
For some odd reason setting a default width on the panel causes the codemirror-measure class to report the wrong size and cause the code mirror to render the content below and behind the on-line-input.
This approach is a fix but obviously has some consequences.