Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(project-data): Move remote file fetching outside the main path #7378

Merged
merged 8 commits into from
May 7, 2024
Merged

fix(project-data): Move remote file fetching outside the main path #7378

merged 8 commits into from
May 7, 2024

Conversation

gatzjames
Copy link
Contributor

@gatzjames gatzjames commented May 6, 2024 •
edited
Loading

TODO:

  • Settings/Request/RequestGroup modals only need local files so we should get those from another place instead of refetching projects

@gatzjames gatzjames self-assigned this May 6, 2024
@gatzjames gatzjames marked this pull request as ready for review May 7, 2024 10:54
@jackkav jackkav merged commit 74fdf4e into Kong:develop May 7, 2024
7 checks passed
stefancruz pushed a commit to stefancruz/insomnia that referenced this pull request May 8, 2024
@gatzjames @jackkav @stefancruz
fix(project-data): Move remote file fetching outside the main path (K…
af2ca25 
…ong#7378)

* move project fetches outside the projectId loader

* update types

* use a separate loader for listing files

* feedback

* close the palette when the env changes

* cleanup and comments

* clean up naming

* filter our mock server as move target

---------

Co-authored-by: jackkav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkav jackkav jackkav approved these changes

Assignees

@gatzjames gatzjames

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gatzjames @jackkav