Insomnia Sync improvements #6738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
942b955
to
855b774
Compare
marckong
reviewed
Nov 2, 2023
471513b
to
242a424
Compare
jackkav
reviewed
Nov 3, 2023
| return vcs; | ||
| }; | ||
|
|
||
| export default VCSInstance; |
There was a problem hiding this comment.
is there a rationale for using default export here?
jackkav
previously approved these changes
Nov 6, 2023
| }, | ||
| { | ||
| id: 'revert', | ||
| name: 'Revert Changes', |
There was a problem hiding this comment.
would be useful to hae a tooltip here to indicate that its for reseting to latest commit
There was a problem hiding this comment.
Should change to 'Revert to latest commit'
| @@ -25,6 +26,8 @@ interface Props { | |||
| gitSyncEnabled: boolean; | |||
| } | |||
|
|
|||
| const ONE_MINUTE_IN_MS = 1000 * 60; | |||
There was a problem hiding this comment.
what interval did sync update with previously?
There was a problem hiding this comment.
We should document the polling mechanisms in the app
d72640a
to
63f1763
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
jackkav
pushed a commit
to jackkav/insomnia
that referenced
this pull request
Mar 13, 2024
* almost there * pending ui in sync dropdown * branches pending ui * fix snapshot staging issue * staging modal fixes * error handling on sync dropdown * remove unused path * switch to git repo button * branch modal ui update * change get method color * staging modal ui * onclose * update export data modal * fix websocket color * remove export all button from scratchpad * dropdown sections * fetch remote branch properly * test issue * restore changes now works properly * cleanup * cleanup vcs usage * cleanup sync items from workspace * cleanup vcs from modals * remove fragment * turn vcs to instance to avoid module import side-effects * fix e2e tests * poll sync updates every minute * change to named export * Add some docs about data fetching in the app (sse,polling,fetch) * improve revert changes copy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog(Improvements): Multiple improvements done to Insomnia Sync feature: Push/Pull status is reflected properly; Disabled states for actions that cannot happen; Added Pending UI for actions (push/pull/switch branch etc.); Accessibility improvements for all UI related to Insomnia Sync; Switching branches, Restore changes on history, and pulling should now properly reflect on the UI; Added consistent error handling and improved error messages.
Improvements in Insomnia Sync:
Closes INS-3278