Add default request and folder names #6632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18f3f90
to
f27d007
Compare
jackkav
reviewed
Oct 3, 2023
| @@ -916,7 +916,7 @@ export const Debug: FC = () => { | |||
| gRPC | |||
| </span> | |||
| )} | |||
| <span className="truncate">{item.doc.name}</span> | |||
| <span className="truncate">{!isRequestGroup(item.doc) ? item.doc.name || item.doc.url || 'Untitled request' : item.doc.name || 'Untitled folder'}</span> | |||
There was a problem hiding this comment.
seems likely to change, would advise extracting to function perhaps sidebarRequestNameOrFallback(r: Request | RequestGroup | GrpcRequest | WebSocketRequest)
jackkav
approved these changes
Oct 3, 2023
52bb72d
to
c1b8750
Compare
jackkav
added a commit
to jackkav/insomnia
that referenced
this pull request
Nov 24, 2023
* Add default request and folder names in debug and test view * fix sizes * extract function --------- Co-authored-by: jackkav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6614
changelog(Fixes): Fixed issue #6614 where request and folder names would be missing in some cases.