Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve checks on session.logout #6619

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Improve checks on session.logout #6619

merged 1 commit into from
Oct 2, 2023

Conversation

gatzjames
Copy link
Contributor

@gatzjames gatzjames commented Oct 2, 2023 •
edited by filfreire
Loading

changelog(Improvements): Improved parts of the code that check if there is no active session and user has logged out.

  • Check if we have sessionId to call the /logout endpoint
  • Make it fire and forget since we don't handle any errors and continue

@gatzjames gatzjames requested a review from a team October 2, 2023 11:25
@gatzjames gatzjames self-assigned this Oct 2, 2023
@gatzjames gatzjames merged commit 8b85265 into Kong:develop Oct 2, 2023
7 checks passed
@gatzjames gatzjames deleted the fix/logout-guard branch October 2, 2023 11:45
jackkav pushed a commit to jackkav/insomnia that referenced this pull request Nov 24, 2023
@gatzjames @jackkav
do not try to post to /logout if not logged in and make it fire and f…
600a0ad 
…orget (Kong#6619)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filfreire filfreire filfreire approved these changes

Assignees

@gatzjames gatzjames

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gatzjames @filfreire