Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed/issue 5692 - Show autocomplete in GraphQL #5941

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

u1aryz
Copy link
Contributor

@u1aryz u1aryz commented May 4, 2023

changelog(Fixes): Fixed issue #5692 where cmd+space wasn't showing all GQL options

This PR closes #5692

Fixed a bug that prevented autocomplete shortcut keys from working in GraphQL.

@filfreire
Copy link
Member

@gatzjames @jackkav I think this one is good to be merged. Reprodution is pressing CTRL+Space to get the Graphql Query autocomplete suggestions on demand.

@jackkav
Copy link
Contributor

jackkav commented Jul 14, 2023

Looks like a meaningful ubuntu smoke test is failing

@sanderhahn
Copy link

The test that fails seems to be a timeout unrelated to this merge request...

@jackkav jackkav merged commit 8221803 into Kong:develop Aug 30, 2023
7 checks passed
@filfreire
Copy link
Member

@u1aryz you can claim a free tshirt for this PR contribution - find more at https://konghq.com/community/open-source-contribution

@AmyStew
Copy link

AmyStew commented Aug 31, 2023

this 'fix' broke the autocomplete showing when we only pressing space. Please revert. or maybe make that an option in settings for auto complete population... to choose CTRL+space or just space

jackkav added a commit to jackkav/insomnia that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl + Space doesn't open autocomplete dropdown in GraphQL
5 participants