-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API Key auth #5399
Add API Key auth #5399
Conversation
Amended the commit, had an unused import. |
Added support for I started to look into updating the importers (specifically the OpenApi 3 importer), and it seems pretty straight forward, except it hits a limitation in the sense that we can only support ONE I guess it might be seen as a downgrade for some people, if we change the importer in that way, any thoughts/input? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Asamsig I tested this locally, LGTM, thank you for your contribution!
Regarding your comment above:
- I think the default behavior could be kept the OpenAPI importer, meaning there's 1 or more api keys on the security schema, when requests are generated, the api keys go into headers like before
- For Postman importer I've taken the liberty of pushing and adding it to this PR, hope you don't mind.
From my side I think this is in mergeable state, waiting for someone else from @Kong/team-insomnia to also give the 👍
@filfreire Yeah, so if there is only one security scheme, we could use the new auth, but otherwise preserve the current behaviour, that seems reasonable. Awesome that you already updated the Postman importer! |
Updated value of api key input to be masked Extracted constants for API Key auth types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Good one! Thanks for the PR!
Supports header / query parameter in both webrequest and websocket
changelog(Improvements): Added API Key Authentication method for HTTP and WebSocket requests