[INS-1784] Restore previous build behavior #5075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 70f8e7f.
|
Would be cool if there was a test to follow the reproduction steps. The quality of life improvement was sr running twice in common flows to accommodate this build step only for Inso. A better approach might run build sr only when building Inso. Not a blocker to getting things working again though. Thanks @davidfluck-kong |
jackkav
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset reverts #4772, which broke the
insomnia-insoNPM package due to a build error in one of its dependencies,insomnia-send-request.The GitHub action to build and publish our NPM packages runs
npm run bootstrap, which used to runbuild:sr, but now skips it entirely.build:srused to buildsend-requestand shuffled thedist/output intopackages/insomnia-send-request. As a result, all versions ofinsomnia-insobetween3.1.0-beta.4and the current beta,3.4.1-beta.0, do not run correctly, and will produce something resembling the following error:Since the original PR seems like a quality-of-life change, I decided to temporarily restore the previous run script behavior to fix the build until we can come up with a better solution. Similarly, I'll make a separate ticket and submit a separate PR to add a test somewhere to make sure Inso, when installed from the NPM
insomnia-insopackage, runs correctly.changelog(Inso CLI): Fixed the broken
run testcommand when using Inso CLI installed from NPM. This issue affected all versions of theinsomnia-insonpm package between3.1.0-beta.4and the current beta,3.4.1-beta.0.