Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Request Switcher Auto-Focus from CodeMirror #5002

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

daniel-stoneuk
Copy link
Contributor

@daniel-stoneuk daniel-stoneuk commented Jul 25, 2022

changelog(Fixes): Fixed an edge-case issue where Request Switcher search input would not auto-focus

Fixes the input .focus() method call. The simplest fix I found was to revert the change in 3cf464d.

There don't seem to be any new problems in the current application from reverting this commit's relevant changes. The original source of the bug may no longer be present.

Closes #4797

@daniel-stoneuk daniel-stoneuk changed the title Fix #4797 request switcher auto-focus from CodeMirror Fix Request Switcher Auto-Focus from CodeMirror Jul 25, 2022
@filfreire filfreire requested a review from a team July 26, 2022 16:43
Copy link
Member

@filfreire filfreire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working ok now 👍 😎

Thank you @daniel-stoneuk

Fixes the input `.focus()` method call. The simplest fix was to revert the change in 3cf464d.

There do not seem to be any new problems in the current application from reverting this commit's relevant changes, indicating that the original cause of the bug is no longer present.
Copy link
Contributor

@gatzjames gatzjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! +100 for removing the dontFocus prop

@gatzjames gatzjames enabled auto-merge (squash) July 28, 2022 11:10
@gatzjames gatzjames merged commit fa7dd44 into Kong:develop Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quick Switch text field does not auto-focus when opening it while Preview search box is focused
3 participants