graphql empty url error #4835
Merged
graphql empty url error #4835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jackkav one minor improvement: the message leave it up to you do it in this PR or not 👍
|
9cccb9f
to
33c9e87
Compare
I think something like "Enter a URL to fetch schema" would be better (instructive on what the user could do). Agree this is an optimization that could be done later if needed. |
|
I've opted for no message, in the no url case, to keep the clutter to a minimum |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: after adding the quick GraphQL request button, an error from the introspection query would be shown because there is no default url.
The introspection query only runs with a url now.
changelog(Fixes): Fixed an issue where users would see a fetch error before defining a URL for brand new GraphQL requests