Added error handling for github auth urls

[Wazbat]

Changelog(Improvements): Improved error messages for Github Sync

I'm not sure how best show these errors to the user, but I feel that instead of these two console.error's that I added there should be some kind of error modal or something like that, but I'm not sure how best to do that in this project

[jackkav]

you'll need to copy the error setState hook and html in the same places as GitHubRepositoryForm

const [error, setError] = useState('');

          {error && (
            <p className="notice error margin-bottom-sm">
              <button className="pull-right icon" onClick={() => setError('')}>
                <i className="fa fa-times" />
              </button>
              {error}
            </p>
          )}

tuck it just inside the closing form tag

[Wazbat]

you'll need to copy the error setState hook and html in the same places as GitHubRepositoryForm

const [error, setError] = useState('');

          {error && (
            <p className="notice error margin-bottom-sm">
              <button className="pull-right icon" onClick={() => setError('')}>
                <i className="fa fa-times" />
              </button>
              {error}
            </p>
          )}

tuck it just inside the closing form tag

I appreciate that. I've gone ahead and added the code. I tested it locally and both errors show and appear to look fine.

Not sure if you'd like me to change the text, as it might be better to go with a more clear definitive The URL you entered is invalid instead of the vague mysterious It appears... message

[jackkav]

Suggested change

	setError('It appears the URL that you entered is incomplete');
	setError('Missing URL');

[Wazbat]

Is "Missing URL" correct? It will only show this error if there is a valid url, howevever the state or code query params are missing

Perhaps Incomplete URL would be better?

[jackkav]

Ah yes I had misread because of the nested if statements perhaps you can use guard pattern to clear up the misunderstanding.

const hasCodeAndState = typeof code === 'string' && typeof state === 'string'
if(!hasCodeAndState) {
  setError('Incomplete URL');
  return;
}
const command = newCommand(COMMAND_GITHUB_OAUTH_AUTHENTICATE, {
  code,
  state,
});

command(dispatch);

[Wazbat]

Gotcha. I've moved that logic up as requested and changed the error text, though I implemented it without the hasCodeAndState variable.

Is it still readable or would you prefer an additional variable to make it easier to understand when glancing over the code?