Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add gitlab oauth provider and ui #4727

Merged
merged 24 commits into from
Jun 1, 2022
Merged

add gitlab oauth provider and ui #4727

merged 24 commits into from
Jun 1, 2022

Conversation

gatzjames
Copy link
Contributor

@gatzjames gatzjames commented Apr 26, 2022 •
edited by dimitropoulos
Loading

Adds a flow for users to sign in with GitLab and use the generated token to perform git operations.

Sign in with GitLab:

gitlab-oauth

Perform git operations in the connected repository:

gitlab-oauth-clone

changelog(Improvements): Added GitLab login for git sync

TODO

  • Add client secret once we create the GitLab app
  • e2e tests
  • Decide on client_id handling (e.g. keep it in the app vs load it from an api)
  • Security Audit

Closes INS-1439

@gatzjames gatzjames force-pushed the gitlab-oauth branch 2 times, most recently from d3b40a6 to de785ea Compare May 18, 2022 11:35
@gatzjames gatzjames marked this pull request as ready for review May 18, 2022 15:58
DMarby
DMarby suggested changes May 18, 2022
View reviewed changes
packages/insomnia/config/config.json Outdated Show resolved Hide resolved
packages/insomnia/src/common/constants.ts Outdated Show resolved Hide resolved
packages/insomnia/config/config.json Outdated Show resolved Hide resolved
packages/insomnia/src/sync/git/gitlab-oauth-provider.ts Outdated Show resolved Hide resolved
...ui/components/modals/git-repository-settings-modal/gitlab-repository-settings-form-group.tsx Outdated Show resolved Hide resolved
packages/insomnia/src/sync/git/gitlab-oauth-provider.ts Outdated Show resolved Hide resolved
@gatzjames gatzjames force-pushed the gitlab-oauth branch 2 times, most recently from c2db7b1 to e783e84 Compare May 24, 2022 11:56
jackkav
jackkav approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@jackkav jackkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with slow internet and unaccepted gitlab T&Cs. Not tested without internet.

@DMarby DMarby self-requested a review May 25, 2022 11:56
@gatzjames gatzjames requested a review from DMarby May 31, 2022 10:15
marckong
marckong approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@marckong marckong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left very few minor comments but they are not blockers.

@gatzjames gatzjames merged commit 4dd89b1 into Kong:develop Jun 1, 2022
@gatzjames gatzjames deleted the gitlab-oauth branch June 1, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marckong marckong marckong approved these changes

@filfreire filfreire filfreire approved these changes

@jackkav jackkav jackkav approved these changes

@DMarby DMarby DMarby approved these changes

Assignees

@gatzjames gatzjames

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gatzjames @DMarby @jackkav @filfreire @marckong