Fix FTI-3278 / INS-1488 missing null type for kong request-validator plugin #4675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMarby
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog(OpenAPI-2-Kong): Fixed an issue where null type was missing on kong declarative config generation for the request-validator plugin when given nullable field on OpenAPI spec.
Context
Related to FTI-3278 / INS-1488. When folks use OpenAPI Spec 3.0.2 spec files and the inso cli tool to generate a Kong declarative configuration, when defining a body schema as
nullable: true, the resulting kong declarative config for the request-validator plugin is missing a "null" type.