remove zprint-clj and EDN beautifying #4603
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the big picture.
We want to move all prettifying to https://www.npmjs.com/package/prettier. That will mean that anything that can be prettified using prettier (or a prettier plugin) (i.e. GraphQL, JSON, YAML, etc.) will be supported by Insomnia. In general, if we have outreach from users to add EDN prettifying back: we can think about it from that direction (i.e. a prettier plugin for EDN).
zprint-clj
We use the
zprint-clj
package for only one thing: prettifying EDN. Here's a little thingy about what EDN is. It's not... shall we say... common. That's not, in itself, a reason not to support prettifying it, please read on:When upgrading this dependency I could not find source code for this npm, nor could I find a changelog. Still.. it appeared to be a straightforward thing to update. It takes EDN (https://github.com/edn-format/edn) and prettifies it.
But then I tried upgrading it and I got:
I thought I could solve it quickly, but I couldn't. There's a shebang at the top of the new release, and there's a few different ways to solve it (babel plugin, webpack loader, etc.) and I can't decide which is best, and none of them are awesome. I did, as I said, test it, but by just deleting the shebang manually.
Why remove prettifying for EDN
This was introduced in #1176. If we see anything from users suggesting a way to keep using it, we can do so.
Note that this doesn't have any impact on EDN syntax highlighting in the code editor.
changelog(Removal): Removed EDN prettifying ahead of a move to prettier for all prettifying