Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove zprint-clj and EDN beautifying #4603

Merged
merged 5 commits into from
Mar 18, 2022

Conversation

dimitropoulos
Copy link
Contributor

@dimitropoulos dimitropoulos commented Mar 16, 2022

What's the big picture.

We want to move all prettifying to https://www.npmjs.com/package/prettier. That will mean that anything that can be prettified using prettier (or a prettier plugin) (i.e. GraphQL, JSON, YAML, etc.) will be supported by Insomnia. In general, if we have outreach from users to add EDN prettifying back: we can think about it from that direction (i.e. a prettier plugin for EDN).

zprint-clj

We use the zprint-clj package for only one thing: prettifying EDN. Here's a little thingy about what EDN is. It's not... shall we say... common. That's not, in itself, a reason not to support prettifying it, please read on:

When upgrading this dependency I could not find source code for this npm, nor could I find a changelog. Still.. it appeared to be a straightforward thing to update. It takes EDN (https://github.com/edn-format/edn) and prettifies it.

But then I tried upgrading it and I got:
Screenshot_20220316_160045

I thought I could solve it quickly, but I couldn't. There's a shebang at the top of the new release, and there's a few different ways to solve it (babel plugin, webpack loader, etc.) and I can't decide which is best, and none of them are awesome. I did, as I said, test it, but by just deleting the shebang manually.

BEFORE AFTER
Screenshot_20220317_111958 Screenshot_20220317_111652

Why remove prettifying for EDN

This was introduced in #1176. If we see anything from users suggesting a way to keep using it, we can do so.

Note that this doesn't have any impact on EDN syntax highlighting in the code editor.

changelog(Removal): Removed EDN prettifying ahead of a move to prettier for all prettifying

@dimitropoulos dimitropoulos self-assigned this Mar 16, 2022
@dimitropoulos dimitropoulos marked this pull request as draft March 16, 2022 21:01
@dimitropoulos dimitropoulos changed the title chore(deps): zprint-clj [WIP] chore(deps): zprint-clj Mar 16, 2022
@dimitropoulos dimitropoulos marked this pull request as ready for review March 17, 2022 15:55
@dimitropoulos dimitropoulos changed the title [WIP] chore(deps): zprint-clj remove zprint-clj and EDN beautifying Mar 17, 2022
@wdawson
Copy link
Contributor

wdawson commented Mar 17, 2022

Looks like this is the least frequently used body type in Insomnia (less than 10 times per day from what we can see). So I'm good with removing for now.

Copy link
Contributor

@jackkav jackkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@dimitropoulos dimitropoulos enabled auto-merge (squash) March 18, 2022 12:19
@dimitropoulos dimitropoulos merged commit 4bffb87 into Kong:develop Mar 18, 2022
@dimitropoulos dimitropoulos deleted the deps/zprint-clj branch March 18, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants