hotfix: invalid OpenAPI spec versions causing the app to crash #4559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
update: I figured out a temporary workaround while we get a patch released. see it here: https://youtu.be/D6yT20GPjZI |
bstncartwright
approved these changes
Mar 8, 2022
filfreire
approved these changes
Mar 9, 2022
gatzjames
approved these changes
Mar 9, 2022
DMarby
pushed a commit
that referenced
this pull request
Mar 9, 2022
DMarby
pushed a commit
that referenced
this pull request
Mar 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenAPI specs do not support the
numberdatatype for$.info.version. Onlystringis supported.In Insomnia, if you change this field to a number, you will see a lint error.
Unfortunately, if you make this change and then flip to the dashboard, the following error appears:
This leaves your application in a totally broken state and there is literally nothing you can do in the app, or do about it to fix it.
This change was introduced in #4319 and would be preventable by spec validation (i.e. AJV) and/or functional TypeScript typings.
Our code is correct in the sense that it follows the spec. The problem is there's a failure-mode for an error case that is quite breaking.
Fixes INS-1477