Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform OAS -> Kong DC JSON rather than YAML #4129

Merged
merged 5 commits into from
Oct 20, 2021
Merged

Transform OAS -> Kong DC JSON rather than YAML #4129

merged 5 commits into from
Oct 20, 2021

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented Oct 19, 2021 •
edited
Loading

Closes INS-1066

This change impacts transforming OpenAPI spec to declarative config. Instead of outputting YAML we output JSON to preserve string values in the OpenAPI spec.

image

@jackkav jackkav changed the title Default inso CLI stdout to JSON Transform OAS -> Kong DC JSON rather than YAML Oct 19, 2021
@vercel vercel bot temporarily deployed to Preview October 19, 2021 11:23 Inactive
@gatzjames gatzjames self-requested a review October 19, 2021 13:00
@vercel vercel bot temporarily deployed to Preview October 19, 2021 15:28 Inactive
develohpanda
develohpanda approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@develohpanda develohpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/insomnia-inso/src/commands/generate-config.test.ts Outdated Show resolved Hide resolved
packages/insomnia-inso/src/commands/generate-config.test.ts Outdated Show resolved Hide resolved
packages/insomnia-inso/src/commands/generate-config.ts Show resolved Hide resolved
plugins/insomnia-plugin-kong-declarative-config/src/generate.js Show resolved Hide resolved
@jackkav jackkav merged commit e0ff79a into Kong:develop Oct 20, 2021
@jackkav jackkav deleted the feat/support-json-output branch October 20, 2021 12:21
@jackkav jackkav mentioned this pull request Oct 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@develohpanda develohpanda develohpanda approved these changes

@gatzjames gatzjames Awaiting requested review from gatzjames

@dimitropoulos dimitropoulos Awaiting requested review from dimitropoulos

Assignees

@jackkav jackkav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackkav @develohpanda @gatzjames