Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/o2k allow whitespace in route paths #4029

Merged
merged 4 commits into from
Sep 20, 2021
Merged

Fix/o2k allow whitespace in route paths #4029

merged 4 commits into from
Sep 20, 2021

Conversation

gatzjames
Copy link
Contributor

@gatzjames gatzjames commented Sep 14, 2021 •
edited
Loading

Updates the route path regex in the openapi-2-kong package to allow for whitespace characters in the path variables.

o2k-fix

Closes INS-895

@gatzjames gatzjames self-assigned this Sep 14, 2021
Tieske
Tieske approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@Tieske Tieske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vercel vercel bot temporarily deployed to Preview September 20, 2021 09:52 Inactive
@gatzjames gatzjames merged commit bc35b48 into Kong:develop Sep 20, 2021
@gatzjames gatzjames deleted the fix/o2k-allow-whitespace-in-route-paths branch September 20, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@develohpanda develohpanda develohpanda approved these changes

@Tieske Tieske Tieske approved these changes

@dimitropoulos dimitropoulos Awaiting requested review from dimitropoulos

Assignees

@gatzjames gatzjames

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gatzjames @Tieske @develohpanda