Add response time in api response to test latency #3465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@develohpanda I created a PR for #3297. Please have a look! |
reynolek
approved these changes
Jun 11, 2021
There was a problem hiding this comment.
Hey @amaaniqbal ! Thanks for the PR. Looking at the code, this is functional and does the requested ask in the open issue.
There is some clean up that I would like to do, mostly around handling the proper types. The function toMs injects an implicit any type, which is one thing we are looking to eliminate going forward. However to fix this, there are larger changes that need to be made in insomnia's networking code, some of which falls out of scope of the PR, and I wouldn't expect any contributor to make those changes.
develohpanda
approved these changes
Jun 11, 2021
develohpanda
pushed a commit
that referenced
this pull request
Jun 22, 2021
* Add response time in api response to test latency * linting fixes Co-authored-by: Eric Reynolds <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3297