[o2k] fix parameter default styles #3327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
develohpanda
suggested changes
Apr 26, 2021
| @@ -62,7 +69,7 @@ function generateParameterSchema(operation?: OA3Operation): Array<Object> | type | |||
| required: !!(p: Object).required, | |||
| name: (p: Object).name, | |||
| schema, | |||
| style: (p: Object).style ?? 'form', | |||
| style: (p: Object).style ?? DEFAULT_PARAM_STYLE[(p: Object).in], | |||
There was a problem hiding this comment.
if p.in is not header, cookie, query or path then this will likely return undefined
PR #3256 changed the default style from "simple" to "form". But that is not correct, the default style depends on the type of parameter. This PR corrects iit and adds the proper style for each of the 4 types of parameters, as specified in the OAS docs here: https://swagger.io/docs/specification/serialization/
develohpanda
approved these changes
Apr 27, 2021
There was a problem hiding this comment.
Looks to be working as expected with the following iterations:
parameters:
- in:
style: acbd
name: userId
schema:
type: integer
required: true
parameters:
- in: asdfadsf
name: userId
schema:
type: integer
required: true
parameters:
- in: path
name: userId
schema:
type: integer
required: true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #3256 changed the default style from "simple" to "form". But that is not correct, the default style depends on the type of parameter.
This PR corrects it and adds the proper style for each of the 4 types of parameters, as specified in the OAS docs here: https://swagger.io/docs/specification/serialization/
fixes INS-654