-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: only change environment on fresh import #2979
fix: only change environment on fresh import #2979
Conversation
Oops, clicked the wrong button by accident 😅 Welcome @apisaint! Great work, I know we have gotten a few reports and requests for this so much appreciated. 🤗 |
I've done it myself many times they are so close to each other!
Thank you! ❤️ Hope to see it merged soon so others can benefit |
c208460
to
c13b691
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! When I functionally tested this (against the steps listed in #2228 (comment)) I still had properties removed in by Base Environment. Is this intended to fix that (I'm assuming so because you said it closes that issue, but I wanted to be sure because otherwise we should track that other part separately).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm, however, after functional testing that the "doesn't automatically change environments" part of this is fixed.
It is not intended to fix that aspect, only switching. Can create another PR for that later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR - the parent issue will remain open but this is good as a partial fix for it.
This change makes it so that when switching between debug and design tabs, it only selects the default environment the first time. Subsequent switches will test whether an active environment id has already been set and ignore.
I've updated the comments as well. Since there were no tests around this area, I did not add or edit any - and will not do so since I am not familiar with the tests infrastructure yet.
Impacts #2228
Impacts #2680