Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only change environment on fresh import #2979

Merged

Conversation

apisaint
Copy link
Contributor

@apisaint apisaint commented Jan 7, 2021

This change makes it so that when switching between debug and design tabs, it only selects the default environment the first time. Subsequent switches will test whether an active environment id has already been set and ignore.

I've updated the comments as well. Since there were no tests around this area, I did not add or edit any - and will not do so since I am not familiar with the tests infrastructure yet.

Impacts #2228
Impacts #2680

@nijikokun nijikokun closed this Jan 11, 2021
@nijikokun nijikokun reopened this Jan 11, 2021
@nijikokun
Copy link
Contributor

Oops, clicked the wrong button by accident 😅

Welcome @apisaint! Great work, I know we have gotten a few reports and requests for this so much appreciated. 🤗

@apisaint
Copy link
Contributor Author

Oops, clicked the wrong button by accident 😅

I've done it myself many times they are so close to each other!

Welcome @apisaint! Great work, I know we have gotten a few reports and requests for this so much appreciated. 🤗

Thank you! ❤️ Hope to see it merged soon so others can benefit

Copy link
Contributor

@dimitropoulos dimitropoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! When I functionally tested this (against the steps listed in #2228 (comment)) I still had properties removed in by Base Environment. Is this intended to fix that (I'm assuming so because you said it closes that issue, but I wanted to be sure because otherwise we should track that other part separately).

Copy link
Contributor

@dimitropoulos dimitropoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm, however, after functional testing that the "doesn't automatically change environments" part of this is fixed.

@apisaint
Copy link
Contributor Author

apisaint commented Mar 1, 2021

Thanks for the contribution! When I functionally tested this (against the steps listed in #2228 (comment)) I still had properties removed in by Base Environment. Is this intended to fix that (I'm assuming so because you said it closes that issue, but I wanted to be sure because otherwise we should track that other part separately).

It is not intended to fix that aspect, only switching. Can create another PR for that later.

Copy link
Contributor

@develohpanda develohpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR - the parent issue will remain open but this is good as a partial fix for it.

@develohpanda develohpanda changed the base branch from develop to release/2021.1 March 3, 2021 04:54
@reynolek reynolek merged commit f1dbd4f into Kong:release/2021.1 Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants