Fix dollar not correctly handled on URI

[MrSnix]

Added dollar sign on URL_PATH_CHARACTER_WHITELIST.
I don't know if there is a better place but seems working as expected.

On query parameters dollars it's still escaped as it should be.

Before

After

It closes #2850

[CLAassistant]

All committers have signed the CLA.

[netlify]

Deploy preview for insomnia-storybook ready!

Built with commit 7caf1a1

https://deploy-preview-2862--insomnia-storybook.netlify.app

[dimitropoulos]

@reynolek do you know if this will be a breaking change? For example, perhaps there are current use-cases that depend on the $ being encoded. I feel like it's probably fine to do what this PR implements, but I'm not sure.

[reynolek]

I am honestly not sure. I feel like we probably should be encoding all special characters and in the event that they are expected to be non-encoded feels like a bug that it still worked.

[MrSnix]

Small news:
I resolved the conflicts and updated the Typescript support.
Just in case it gets merged.

[dimitropoulos]

Maybe I don't have the right context, but this seems like a legit bug when I read through the original issue (#2850).

@develohpanda please also take a look

@reynolek can you say more about what you mean by "special characters" in the context we're talking about. It seems like these characters should be allowed through from my reading of things.

[reynolek]

Yeah looks like $ should be allowed through. I am good with the change as it stems from an RFC, and contains test cases for query params as well as paths, decreasing the chances of breaking it in the future 👍

[MrSnix]

Hello everyone, I want only to say that I did some research some time ago and it turned out that usually:

• Dollar is expected to be encoded if it is a query parameter
• Dollar is not expected to be encoded if it is a path sub delimiter

Source: RFC3986 - Reserved Characters

Anyway, I'm not an expert so everyone is welcome to tell me I'm wrong.

[night-fury-web]

When will it be released?

[reynolek]

@SandGuardian It will come out with our next release. It is currently unscheduled due to a larger body of work that is happening atm, which requires us to do quite a bit of cherry picking and history re-writing to accomplish a release without the new feature (as the new feature isnt ready for release).

I wish I could be more specific, but hopefully not too long, we have a lot of great OSS contributions to release, including this one.