Add metadata fields to openapi-2-kong package.json #2802
Conversation
There was a problem hiding this comment.
Thanks for doing this! One comment, and a question for @nijikokun
packages/openapi-2-kong/package.json
Outdated
| @@ -29,5 +29,8 @@ | |||
| "webpack": "^4.42.1", | |||
| "webpack-cli": "^3.3.11" | |||
| }, | |||
| "repository": "https://github.com/Kong/insomnia/tree/develop/packages/openapi-2-kong", | |||
| "bugs": "https://github.com/Kong/insomnia/issues", | |||
| "license": "MIT", | |||
There was a problem hiding this comment.
@nijikokun should the license be MIT or Apache2? Inso is set to Apache2.
There was a problem hiding this comment.
Just a comment to this question: if you set this to Apache2, I think you should change the licence that is distributed with openapi-2-kong, which is currently MIT:
$ npm pack openapi-2-kong
$ tar xzf openapi-2-kong-2.2.24.tgz
$ cat package/LICENSE
MIT License
Copyright (c) Insomnia REST Client
Permission is hereby granted....For reference why this came to my attention in the first place, see discussion in Kong Nation.
There was a problem hiding this comment.
Format according to npm docs: https://docs.npmjs.com/cli/v6/configuring-npm/package-json#bugs
|
|
|
✔️ Deploy preview for insomnia-storybook ready! 🔨 Explore the source changes: fb37297 🔍 Inspect the deploy logs: https://app.netlify.com/sites/insomnia-storybook/deploys/5fec60831089af0008848a9e 😎 Browse the preview: https://deploy-preview-2802--insomnia-storybook.netlify.app |
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/Kong/insomnia.git", | ||
| "directory": "packages/openapi-2-kong" | ||
| }, |
There was a problem hiding this comment.
Nice improvement here! We should certainly update the other packages to follow this pattern, TIL.
The metadata fields on https://www.npmjs.com/package/openapi-2-kong are a bit scarce, and it would be nice if these were improved: