Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Client Certificate paths #2714

Merged
merged 2 commits into from
Sep 10, 2021

Conversation

thewheat
Copy link
Contributor

Closes: #2300

  • Creates a new div that lists one file per line with some padding to help indicate line is grouped to upper row
  • There is an extra gap between the lines that I'm not sure how to get rid (not to familiar with flex box 😅 but a negative margin seems to be a possible option)
  • Happy for any other comments or feedback especially in terms of how we'd want to display this 👍

Before
image

After
image

I

@CLAassistant
Copy link

CLAassistant commented Dec 6, 2020

CLA assistant check
All committers have signed the CLA.

@dimitropoulos
Copy link
Contributor

dimitropoulos commented Sep 9, 2021

I updated to do a few things:

  • no duplication anymore (i.e. the thing with the checkbox as well as a row with the path)
  • network hierarchy is represented now (see https://github.com/Kong/insomnia/blob/develop/packages/insomnia-app/app/network/network.ts#L547, but basically if there's a cert and a pfx, the pfx will win and the UI will now represent that).
  • optional fields are not represented (e.g. passphrase, key)
  • the passphrase is not now always visible in a tooltip, but instead is in a password viewer eyeball thingy (that respects the global setting for password reveal!)

Screenshot_20210909_142806

Copy link
Contributor

@gatzjames gatzjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Paths of Client Certs in Workspace Settings -> Client Certificates
5 participants