Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling Font Ligatures does not disable in Collection Pain #4813

Closed
1 task done
Midnex opened this issue May 23, 2022 · 1 comment · Fixed by #4891
Closed
1 task done

Disabling Font Ligatures does not disable in Collection Pain #4813

Midnex opened this issue May 23, 2022 · 1 comment · Fixed by #4891
Labels
B-bug Bug: general classification N-investigation Needs: investigation S-verified Status: Verified by maintainer

Comments

@Midnex
Copy link

Midnex commented May 23, 2022

Expected Behavior

When disabling Font Ligatures it should disable them throughout the entire app.

Actual Behavior

Parts of the GUI continue to show font ligatures. While this is ugly when using a normal font, it is exzaerbated when using Arch and a Nerd font such as NotoSans Mono.

System fonts (notice the Fs) with Ligatures Disabled
image

NotoSans Mono Nerd Font on Arch with Ligatures disabled
image

Reproduction Steps

  1. Install a font such as NotoSans Mono Nerd Font or other Nerd Font.
  2. Create a new folder without adding any request to it.
  3. Disable font ligatures
  4. Look at Interface, In settings they are shown disabled, and disabled. In Preview response, they are disabled, in request collection they are still enabled.

Is there an existing issue for this?

Additional Information

Using Arch based Linux, there is a known issue with font ligatures on nerd fonts, which only exacerbate the problem, on windows it is far less noticeable. However on Arch Linux it is very noticeable that disabled ligatures only disabled it in some places.

Here you can see the top example with FI not working, and the bottom example it working fine.
image

Insomnia Version

2022.3.0

What operating system are you using?

Other Linux

Operating System Version

Linux 5.15.32-1-MANJARO x86_64 GNU/Linux

Installation method

pacman

Last Known Working Insomnia version

None, been broke ever since I can remember.

@Midnex Midnex added B-bug Bug: general classification S-unverified Status: Unverified by maintainer labels May 23, 2022
@filfreire filfreire added the N-investigation Needs: investigation label May 25, 2022
@dimitropoulos dimitropoulos added the insomnia-stream a good candidate to look at during the weekly livestream (see #stream on https://chat.insomnia.rest) label Jun 7, 2022
@dimitropoulos
Copy link
Contributor

dimitropoulos commented Jun 7, 2022

We were able to reproduce on the stream, and did find the cause but we need to find a fix. It has to do with a user-agent stylesheet for button. See the link to the stream in the first sentence to see when we discover this.

To reproduce add a font like https://github.com/tonsky/FiraCode/releases/tag/6.2 that supports ligatures and then rename a request to include ===. Note that no matter what setting you set in insomnia, it remains with ligatures.

@dimitropoulos dimitropoulos added S-verified Status: Verified by maintainer N-investigation Needs: investigation and removed S-unverified Status: Unverified by maintainer insomnia-stream a good candidate to look at during the weekly livestream (see #stream on https://chat.insomnia.rest) N-investigation Needs: investigation labels Jun 7, 2022
vincendep pushed a commit to vincendep/insomnia that referenced this issue Jun 23, 2022
apply font-ligatures-variant style to all elements
filfreire added a commit that referenced this issue Jun 29, 2022
apply font-ligatures-variant style to all elements

Co-authored-by: Vincenzo De Petris <[email protected]>
Co-authored-by: Filipe Freire <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-bug Bug: general classification N-investigation Needs: investigation S-verified Status: Verified by maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants