CO-636 Incorrect photo coming in notification popup for messages sent from dashboard #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devashishmamgain
approved these changes
Jul 25, 2019
ab14bhardwaj
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case you fixed a bug then please describe the root cause of it?
-> Fixed an issue whenever any agent was sending a message from the dashboard to the user on the chat widget then the image that was showing on the popup widget was of the assignee of that conversation and not the one of the agent that sent that message.
How was the code tested?
-> The code was tested by sending the messages to the chat widget where the widget is minimized (closed).
-> Also tested by sending the messages from those agents who are not part of the conversation initially but later added in the conversation.
NOTE: Make sure you're comparing your branch with the correct base branch