[CM-2026] Added Support for EU Servers #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sathyan-KM
reviewed
Apr 19, 2024
Comment on lines
72
to
78
| switch (serverConfigText) { | ||
| case "euConfiguration": | ||
| this.serverConfig = KMServerConfiguration.EUCONFIGURATION; | ||
| Kommunicate.setServerConfiguration(context, KMServerConfiguration.DEFAULTCONFIGURATION); | ||
| break; | ||
| default: | ||
| result.error(ERROR, "It only supports `euConfiguration` for now.", null); |
There was a problem hiding this comment.
add if else instead of switch..also call native function for else block as well
| @@ -157,6 +180,9 @@ public void onFailure(RegistrationResponse registrationResponse, Exception excep | |||
| try { | |||
| String appId = (String) call.arguments(); | |||
| if (!TextUtils.isEmpty(appId)) { | |||
| if (serverConfig == KMServerConfiguration.EUCONFIGURATION) { | |||
| Kommunicate.setServerConfiguration(context, serverConfig); | |||
| } | |||
There was a problem hiding this comment.
Don't we need cover default config as well?
There was a problem hiding this comment.
Why during login we are internally setting this?
There was a problem hiding this comment.
removed unnecessary calls of Kommunicate.setServerConfiguration.
Sathyan-KM
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Login as Visitor,Login UserorBuild conversation" in Android.didFinishLaunchingWithOptionsand before any of these "Login as Visitor,Login UserorBuild conversation". (Reason: when the app is Closed and reopened at that time the server got reset to default. To overcome the issue we can add the config in AppDelegatedidFinishLaunchingWithOptions.)Login as Visitor,Login UserorBuild conversation"